Mercurial > public > sg101
view gpp/forums/feeds.py @ 387:b15726767ab8
Fixing #191; terrible performance on the combined forums RSS feed query. Use an .extra() clause to force the WHERE on a query to use the primary key.
author | Brian Neal <bgneal@gmail.com> |
---|---|
date | Sat, 19 Mar 2011 01:52:41 +0000 |
parents | 2a03c69792d8 |
children | c3231af55778 |
line wrap: on
line source
"""This file contains the feed class for the forums application.""" from django.contrib.syndication.views import Feed from django.core.exceptions import ObjectDoesNotExist from django.shortcuts import get_object_or_404 from forums.models import Forum from forums.models import Post from core.functions import copyright_str class ForumsFeed(Feed): """The Feed class for a specific forum""" ttl = '60' author_name = 'Brian Neal' author_email = 'admin@surfguitar101.com' def get_object(self, request, forum_slug): # only return public forums if forum_slug: forum = get_object_or_404(Forum, slug=forum_slug) if forum.id not in Forum.objects.public_forum_ids(): raise ObjectDoesNotExist return forum else: # return None to indicate we want a combined feed return None def title(self, obj): if obj is None: forum_name = 'Combined' else: forum_name = obj.name return 'SurfGuitar101.com %s Forum Feed' % forum_name def link(self, obj): if obj is None: bits = '' else: bits = obj.slug + '/' return '/feeds/forums/' + bits def description(self, obj): if obj is None: return "User posts to SurfGuitar101.com forums." return obj.description def feed_copyright(self): return copyright_str() def items(self, obj): if obj is None: # return a combined feed of public forum threads # # This didn't work real well on InnoDb: # items = Post.objects.filter( # topic__forum__in=Forum.objects.public_forums()) # # The where clause in the generated SQL looked like this: # WHERE `forums_topic`.`forum_id` IN ( ... ) # This was terrible for performance. This does much better: # WHERE `forums_topic`.`id` IN ( ... ) # # So we use Django's .extra() to force the above. public_forum_ids = Forum.objects.public_forum_ids() ids = ','.join(str(pub) for pub in public_forum_ids) items = Post.objects.extra( where=['forums_topic.id in (%s)' % ids]) else: items = Post.objects.filter(topic__forum__id=obj.id) return items.order_by('-creation_date').select_related(depth=2)[:30] def item_title(self, item): return item.topic.name def item_description(self, item): return item.html def item_author_name(self, item): return item.user.username def item_pubdate(self, item): return item.creation_date def item_categories(self, item): return (item.topic.forum.name, )