Mercurial > public > sg101
view forums/views/attachments.py @ 1037:7e0c3cbd3cda
Fix bad select_related call.
In Django 1.8, select_related now throws an error if you give it an invalid
field. This was happening. Fix that query.
Also noticed an extra query generated in the display_post template. Fixed.
author | Brian Neal <bgneal@gmail.com> |
---|---|
date | Tue, 29 Dec 2015 22:21:42 -0600 |
parents | 89b240fe9297 |
children |
line wrap: on
line source
""" This module contains views for working with post attachments. """ import json from django.http import HttpResponse from django.http import HttpResponseForbidden from django.http import HttpResponseBadRequest from django.http import HttpResponseNotFound from forums.models import Attachment from forums.models import Post def fetch_attachments(request): """ This view is the target of an AJAX GET request to retrieve the attachment embed data for a given forum post. """ if not request.user.is_authenticated(): return HttpResponseForbidden('Please login or register.') post_id = request.GET.get('pid') if post_id is None: return HttpResponseBadRequest('Missing post ID.') try: post = Post.objects.get(pk=post_id) except Post.DoesNotExist: return HttpResponseNotFound("That post doesn't exist.") attachments = Attachment.objects.filter(post=post).select_related('embed') data = [{'id': a.embed.id, 'html': a.embed.html} for a in attachments] return HttpResponse(json.dumps(data), content_type='application/json')