Mercurial > public > sg101

diff gpp/bio/views.py @ 265:1ba2c6bf6eb7

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Closing #98. Animated GIFs were losing their transparency and animated properties when saved as avatars. Reworked the avatar save process to only run the avatar through PIL if it is too big. This preserves the original uploaded file if it is within the desired size settings. This may still mangle big animated gifs. If this becomes a problem, then maybe look into calling the PIL Image.resize() method directly. Moved the PIL image specific functions from bio.forms to a new module: core.image for better reusability in the future.
author Brian Neal <bgneal@gmail.com>
date Fri, 24 Sep 2010 02:12:09 +0000
parents 75ea1a8be7f2
children 000c006fee97
line wrap: on
line diff
--- a/gpp/bio/views.py	Thu Sep 23 01:16:26 2010 +0000
+++ b/gpp/bio/views.py	Fri Sep 24 02:12:09 2010 +0000
@@ -144,12 +144,21 @@
     if request.method == 'POST':
         form = UploadAvatarForm(request.POST, request.FILES)
         if form.is_valid():
+            # Update the profile with the new avatar
             profile = request.user.get_profile()
-            file = form.get_file()
+
+            # First delete any old avatar file
             if profile.avatar.name != '':
                 profile.avatar.delete(save=False)
-            if file is not None:
-                profile.avatar.save(form.get_filename(), file, save=False)
+
+            try:
+                name, avatar = form.save()
+            except IOError:
+                messages.error(request, 'A file error occurred.')
+                return HttpResponseRedirect(reverse('bio-me'))
+
+            if avatar is not None:
+                profile.avatar.save(name, avatar, save=False)
             profile.save()
 
             messages.success(request, 'Avatar updated')