Mercurial > public > sg101
comparison gpp/bio/views.py @ 265:1ba2c6bf6eb7
Closing #98. Animated GIFs were losing their transparency and animated properties when saved as avatars. Reworked the avatar save process to only run the avatar through PIL if it is too big. This preserves the original uploaded file if it is within the desired size settings. This may still mangle big animated gifs. If this becomes a problem, then maybe look into calling the PIL Image.resize() method directly. Moved the PIL image specific functions from bio.forms to a new module: core.image for better reusability in the future.
author | Brian Neal <bgneal@gmail.com> |
---|---|
date | Fri, 24 Sep 2010 02:12:09 +0000 |
parents | 75ea1a8be7f2 |
children | 000c006fee97 |
comparison
equal
deleted
inserted
replaced
264:91c0902de04d | 265:1ba2c6bf6eb7 |
---|---|
142 @login_required | 142 @login_required |
143 def change_avatar(request): | 143 def change_avatar(request): |
144 if request.method == 'POST': | 144 if request.method == 'POST': |
145 form = UploadAvatarForm(request.POST, request.FILES) | 145 form = UploadAvatarForm(request.POST, request.FILES) |
146 if form.is_valid(): | 146 if form.is_valid(): |
147 # Update the profile with the new avatar | |
147 profile = request.user.get_profile() | 148 profile = request.user.get_profile() |
148 file = form.get_file() | 149 |
150 # First delete any old avatar file | |
149 if profile.avatar.name != '': | 151 if profile.avatar.name != '': |
150 profile.avatar.delete(save=False) | 152 profile.avatar.delete(save=False) |
151 if file is not None: | 153 |
152 profile.avatar.save(form.get_filename(), file, save=False) | 154 try: |
155 name, avatar = form.save() | |
156 except IOError: | |
157 messages.error(request, 'A file error occurred.') | |
158 return HttpResponseRedirect(reverse('bio-me')) | |
159 | |
160 if avatar is not None: | |
161 profile.avatar.save(name, avatar, save=False) | |
153 profile.save() | 162 profile.save() |
154 | 163 |
155 messages.success(request, 'Avatar updated') | 164 messages.success(request, 'Avatar updated') |
156 return HttpResponseRedirect(reverse('bio-me')) | 165 return HttpResponseRedirect(reverse('bio-me')) |
157 else: | 166 else: |